Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the route cache and other build internals #2503

Merged
merged 4 commits into from
Jan 31, 2022
Merged

refactor the route cache and other build internals #2503

merged 4 commits into from
Jan 31, 2022

Conversation

FredKSchott
Copy link
Member

Changes

  • Refactor the routeCache into a custom class
  • Remove duplicate calls to getStaticPaths() from build pipeline
  • Improve the rss() implementation to pass data more explicitly
  • Improve thrown errors to no longer hide the stack trace

Testing

  • Covered by existing tests.

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: fee594f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 30, 2022
@FredKSchott FredKSchott force-pushed the route-cache-refactor branch 4 times, most recently from 2e8ce11 to 44d980d Compare January 31, 2022 03:20
matthewp
matthewp approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

Base automatically changed from refactor-dev-server-1 to main January 31, 2022 19:44
@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: fee594f

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f83eac6d23570008073569

😎 Browse the preview: https://deploy-preview-2503--astro-docs-2.netlify.app

@matthewp matthewp merged commit de9fadb into main Jan 31, 2022
@matthewp matthewp deleted the route-cache-refactor branch January 31, 2022 20:05
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@FredKSchott @matthewp
refactor the route cache and other build internals (withastro#2503)
4c7ca48 
* refactor dev to use vite server

* refactor the route cache and other build internals

* use debug package for debug logs (withastro#2504)

Co-authored-by: Matthew Phillips <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @matthewp